Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix #593, only call removeAttribute when have the method #594

Merged
merged 1 commit into from
Jan 17, 2017

Conversation

JiaLiPassion
Copy link
Collaborator

Fix #593, the issue can be described as following case.

  var xhr = new XMLHttpRequest();
  console.log('property', xhr.onreadystatechange);

When first time try to get xhr.onreadystatechange, it will access patched getter, and because
canPatchPropertyDescriptor change the getter which always return true, so the logic will go to
this.removeAttribute part which is not correct (this.removeAttribute is only for DOMElement).

@JamesHenry
Copy link

Awesome! Just got bitten by this, rolling back to 0.6.x works until this patch gets released

@mhevery mhevery merged commit 1401d60 into angular:master Jan 17, 2017
@JiaLiPassion JiaLiPassion deleted the issue-593 branch January 17, 2017 22:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants