The "typeof element.oninput" changes with Zone.js (object vs. function) #540

mkdynamic · 2016-12-13T11:34:08Z

Test case to reproduce:

<!DOCTYPE html>
<html>
  <body>
    <script>
      var test = function() {
        var input = document.createElement("input");
        input.setAttribute("oninput", "return");
        return typeof input.oninput;
      };

      document.write("<div>before zone.js: " + test() + "</div>");
    </script>

    <script src="https://cdnjs.cloudflare.com/ajax/libs/zone.js/0.7.2/zone.min.js"></script>

    <script>
      document.write("<div>after zone.js: " + test() + "</div>");
    </script>
  </body>
</html>

This outputs the following:

before zone.js: function
after zone.js: object

This breaks Modernizr’s feature detection for "oninput" (it assumed a function type):
https://github.com/Modernizr/Modernizr/blob/master/feature-detects/event/oninput.js#L29

The text was updated successfully, but these errors were encountered:

JiaLiPassion · 2016-12-13T14:01:45Z

after zone.js, the function become object because it will be null.
I found the same issue in #525, and I found a solution recently, I'll make a PR to fix it.

JiaLiPassion mentioned this issue Dec 13, 2016

fix inline event handler issue #525 #540 #541

Merged

mhevery closed this as completed in 20b5a5d Dec 18, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The "typeof element.oninput" changes with Zone.js (object vs. function) #540

The "typeof element.oninput" changes with Zone.js (object vs. function) #540

mkdynamic commented Dec 13, 2016

JiaLiPassion commented Dec 13, 2016

The "typeof element.oninput" changes with Zone.js (object vs. function) #540

The "typeof element.oninput" changes with Zone.js (object vs. function) #540

Comments

mkdynamic commented Dec 13, 2016

JiaLiPassion commented Dec 13, 2016