This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix(setTimeout): allow clearTimeout to be called in setTimeout callback #301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #290 - "More tasks executed than were scheduled" error.
The change is to set task.cancelFn = null before invoking a task for non-periodic tasks. As it is no longer possible to cancel the task which is just about to be invoked, I think this should be ok. I also updated the setTimeout tests to create new zones to run the tests in, as initially the test was incorrectly passing due to the task counts not being 0 to begin with.