This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix(xhr): should invoke xhr task after onload is triggered #1055
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix angular/angular#20921
fix angular/angular#17192
currently
zone.js
patchxhr
as amacroTask
and afterxhr.send
,zone.js
will add areadystatechange
listener, whenreadystate=4
, themacroTask
will be invoked.this logic work fine, but because
xhr
can also addonload
oraddEventListener('load', listener)
.and the
load
event handler will run afterreadystatechange
, so in theload
event handler, the zone may have been stabled, and cause some issues. such as in angular/angular#20921, thechained http
will trigger multiplezone.stable
, and angular/angular#17192, the onload will run outside of fixture.whenStable.So in this PR, I just make sure all
onload
is finished, then finally invoked the internalreadystatechange
task.