fix: throw if a zone does not define an onError hook

angular · Mar 28, 2014 · 3485c1b · 3485c1b
1 parent bf5b79e
commit 3485c1b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/test/zone.spec.js b/test/zone.spec.js
@@ -172,6 +172,12 @@ describe('Zone.patch', function () {
       expect(leaveSpy).toHaveBeenCalled();
     });
 
+    it('should throw if onError is not defined', function () {
+      expect(function () {
+        zone.run(throwError);
+      }).toThrow();
+    });
+
     it('should fire onError if a function run by a zone throws', function () {
       var errorSpy = jasmine.createSpy();
       var myZone = zone.fork({
@@ -180,9 +186,9 @@ describe('Zone.patch', function () {
 
       expect(errorSpy).not.toHaveBeenCalled();
 
-      myZone.run(function () {
-        throw new Error('test');
-      });
+      expect(function () {
+        myZone.run(throwError);
+      }).not.toThrow();
 
       expect(errorSpy).toHaveBeenCalled();
     });
@@ -222,3 +228,7 @@ describe('Zone.patch', function () {
   });
 
 });
+
+function throwError () {
+  throw new Error();
+}
diff --git a/zone.js b/zone.js
@@ -42,6 +42,8 @@ Zone.prototype = {
     } catch (e) {
       if (zone.onError) {
         zone.onError(e);
+      } else {
+        throw e;
       }
     } finally {
       this.onZoneLeave();