Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(): add event object for slide-toggle and checkbox. #554

Merged
merged 3 commits into from
May 31, 2016
Merged

update(): add event object for slide-toggle and checkbox. #554

merged 3 commits into from
May 31, 2016

Conversation

devversion
Copy link
Member

Closes #552.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 27, 2016
jelbourn
jelbourn reviewed May 27, 2016
View reviewed changes
src/components/checkbox/checkbox.ts
// A simple change event emitted by the MdCheckbox component.
export class MdCheckboxChange {
source: MdCheckbox;
value: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for checkbox and slide-toggle we'd want the property to be checked instead of value

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn merged commit 55cc197 into angular:master May 31, 2016
@devversion devversion deleted the update/checkbox-emit-value branch August 1, 2016 15:52
@devversion devversion mentioned this pull request Dec 10, 2016
Open
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkbox should emit its own event object instead of boolean
3 participants
@devversion @jelbourn @googlebot