fix(): visual hidden inputs should not bubble change event #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| }) | ||
| class CheckboxWithChangeEvent { | ||
| handleChange(): void {} | ||
| handleChange(event: any): void {} |
devversion
force-pushed
the
fix/checkbox-event-emit
branch
from
c40893b
to
5bd4881
Compare
|
FYI @iveysaur for button-toggle |
* Currently the change event of the visual hidden inputs will bubble up and emit its event object to the component's `change` output. This is currently an issue of Angular 2 - See angular/angular#4059 To prevent the events from bubbling up, we have to stop propagation on change. Fixes angular#544.
devversion
force-pushed
the
fix/checkbox-event-emit
branch
from
5bd4881
to
aba553c
Compare
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changeoutput.This is currently an issue of Angular 2
To prevent the events from bubbling up, we have to stop propagation on
change.
Fixes #544.