Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autocomplete): error when clicking outside instance without mdInput #4573

Merged

Conversation

crisbeto
Copy link
Member

Fixes an error that was being thrown if md-autocomplete is used on an input that's not a part of an md-input-container.

Fixes #4555.

Fixes an error that was being thrown if `md-autocomplete` is used on an input that's not a part of an `md-input-container`.

Fixes angular#4555.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 15, 2017
@@ -1373,6 +1392,33 @@ class AutocompleteWithOnPushDelay implements OnInit {
}
}

@Component({
template: `
<input mdInput placeholder="Choose" [mdAutocomplete]="auto" [formControl]="optionCtrl">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove mdInput here?

@kara kara assigned crisbeto and unassigned kara May 15, 2017
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 15, 2017
@jelbourn jelbourn merged commit e6f7ace into angular:master May 17, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete throws error in 2.0.0-beta.5
4 participants