fix(slider): make disabled state look like mocks #2604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
requested review from
tinayuangao
and removed request for
andrewseguin
tinayuangao
reviewed
Jan 12, 2017
| @@ -245,11 +246,24 @@ export class MdSlider implements ControlValueAccessor { | |||
| return (this.direction == 'rtl' && !this.vertical) ? !this.invertAxis : this.invertAxis; | |||
| } | |||
|
|
|||
| get thumbGap() { | |||
There was a problem hiding this comment.
Could you please add some docs about these values?
jelbourn
reviewed
Jan 12, 2017
| * elements. | ||
| */ | ||
| get thumbGap() { | ||
| return this.disabled ? 7 : 0; |
| * The amount of space to leave between the slider thumb and the track fill & track background | ||
| * elements. | ||
| */ | ||
| get thumbGap() { |
There was a problem hiding this comment.
This looks like it can be private
|
Done |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #2603 making slider look like mocks for all states