feat(autocomplete): add value support #2516
Conversation
googlebot
added
the
cla: yes
kara
force-pushed
the
autocomplete-forms
branch
from
902d72b
to
c6112aa
Compare
kara
force-pushed
the
autocomplete-forms
branch
6 times, most recently
from
c541077
to
30e83a9
Compare
kara
added
in progress
kara
force-pushed
the
autocomplete-forms
branch
from
30e83a9
to
24c94ec
Compare
kara
added
pr: needs review
and removed
in progress
kara
force-pushed
the
autocomplete-forms
branch
4 times, most recently
from
b8cb2df
to
f431e49
Compare
| </md-card> | ||
|
|
||
| <md-card> | ||
| <div>TD value (currentState): {{ currentState }}</div> |
There was a problem hiding this comment.
Fixed to "template-driven" for clarity
| */ | ||
| private _subscribeToClosingActions(): void { | ||
| this.autocomplete.options.changes | ||
| .startWith(null) |
There was a problem hiding this comment.
Add comment explaining what this does? I don't know what startWith(null) is for or what switchMap does
| */ | ||
| private _setValueAndClose(event: MdOptionSelectEvent | null): void { | ||
| if (event) { | ||
| // TODO(kara): revisit animation once floating placeholder is toggle-able |
There was a problem hiding this comment.
TODO probably isn't necessary any more
| expect(fixture.componentInstance.stateCtrl.dirty) | ||
| .toBe(false, `Expected control to stay pristine if value is set programmatically.`); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Should there be any tests for touched state?
There was a problem hiding this comment.
That should be tested by the forms module and/or mdInput. The autocomplete doesn't actually touch those events, so seems duplicative to test here.
kara
force-pushed
the
autocomplete-forms
branch
2 times, most recently
from
78a5be9
to
e21a8e1
Compare
|
@jelbourn Comments addressed! |
jelbourn
added
pr: lgtm
action: merge
kara
force-pushed
the
autocomplete-forms
branch
from
e21a8e1
to
e4c8a67
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Autocomplete is WIP. This is a small piece to add value population.
Note: The placeholder animation will still happen when setting the value. This will be fixed in a later PR once floating placeholders are more configurable in input.