Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): add all providers to forRoot #2222

Merged
merged 2 commits into from
Dec 14, 2016

Conversation

crisbeto
Copy link
Member

Adds all of the necessary providers to the A11yModule.

Fixes #2189.

Adds all of the necessary providers to the `A11yModule`.

Fixes angular#2189.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 14, 2016
@@ -16,7 +16,7 @@ export class A11yModule {
static forRoot(): ModuleWithProviders {
return {
ngModule: A11yModule,
providers: A11Y_PROVIDERS,
providers: PlatformModule.forRoot().providers.concat(A11Y_PROVIDERS),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do

providers: [
  PlatformModule.forRoot().providers, 
  A11Y_PROVIDERS,
],

Angular will flatten the list

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice, TIL. It's changed.

@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 14, 2016
@jelbourn jelbourn merged commit 9272b4b into angular:master Dec 14, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A11yModule.forRoot() does not include providers from MdPlatformModule
3 participants