Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11yModule.forRoot() does not include providers from MdPlatformModule #2189

Closed
jelbourn opened this issue Dec 13, 2016 · 2 comments · Fixed by #2222
Closed

A11yModule.forRoot() does not include providers from MdPlatformModule #2189

jelbourn opened this issue Dec 13, 2016 · 2 comments · Fixed by #2222
Assignees
@crisbeto
Labels
P2 The issue is important to a large percentage of users, with a workaround

Comments

@jelbourn
Copy link
Member

Each module's forRoot should include all of the providers in its dependency chain.
@jelbourn jelbourn added the P2 The issue is important to a large percentage of users, with a workaround label Dec 13, 2016
@jelbourn
Copy link
Member Author

@crisbeto could you take this one?

@crisbeto crisbeto self-assigned this Dec 13, 2016
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 14, 2016
@crisbeto
fix(a11y): add all providers to forRoot
58b6a54 
Adds all of the necessary providers to the `A11yModule`.

Fixes angular#2189.
@crisbeto crisbeto mentioned this issue Dec 14, 2016
Merged
jelbourn pushed a commit that referenced this issue Dec 14, 2016
@crisbeto @jelbourn
fix(a11y): add all providers to forRoot (#2222)
9272b4b 
* fix(a11y): add all providers to forRoot

Adds all of the necessary providers to the `A11yModule`.

Fixes #2189.

* Remove redundant concat.
@crisbeto crisbeto mentioned this issue Dec 15, 2016
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(a11y): add all providers to forRoot crisbeto/material2
2 participants
@jelbourn @crisbeto