-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sidenav): resolve promise as false rather than #1930
Conversation
rejecting it when the toggle animation is canceled. also clean up the overly complex promise logic
@@ -134,15 +143,15 @@ export class MdSidenav implements AfterContentInit { | |||
|
|||
/** Open this sidenav, and return a Promise that will resolve when it's fully opened (or get | |||
* rejected if it didn't). */ | |||
open(): Promise<void> { | |||
open(): Promise<boolean> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than emitting a boolean
directly, can we create an event object and include this information? That lets us add additional information to the event in the future.
Done |
fixes #1899 |
LGTM |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
rejecting it when the toggle animation is canceled. also clean up the
overly complex promise logic