Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MdDialog Feature Request: Ability to change Width and off-set #1698

Closed
bkarv opened this issue Nov 2, 2016 · 2 comments · Fixed by #1848
Closed

MdDialog Feature Request: Ability to change Width and off-set #1698

bkarv opened this issue Nov 2, 2016 · 2 comments · Fixed by #1848
Assignees
@crisbeto
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix

Comments

@bkarv
Copy link

bkarv commented Nov 2, 2016 •
edited
Loading

Feature Request

Ability to set width of Dialog and dialog off-set (x,y) through input parameters so that dialogs can be made responsive to the screen media. For example on mobile media the programmer could set dialog box to be 100% and off-set would be set to 0,0 so it takes up the entire screen. For desktop media the programmer would set to default standard position that is in the centre.
@jelbourn jelbourn added the feature This issue represents a new feature or feature request rather than a bug or bug fix label Nov 4, 2016
@jelbourn
Copy link
Member

jelbourn commented Nov 4, 2016

@crisbeto this has been an intended feature, we should chat about the API

crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 13, 2016
@crisbeto
feat(dialog): add configurable width, height and position
828aa84 
* Adds the ability to set a dialog's `width` and `height`.
* Adds the ability to set a dialog's position. If only the position in one axis is overridden, the other axis will stay centered.
* Fixes the `GlobalPositionStrategy` adding an unnecessary `0px` transform.
* Makes the dialog scrollable.

Fixes angular#1698.
@crisbeto crisbeto mentioned this issue Nov 13, 2016
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 13, 2016
@crisbeto
feat(dialog): add configurable width, height and position
e23e0b1 
* Adds the ability to set a dialog's `width` and `height`.
* Adds the ability to set a dialog's position. If only the position in one axis is overridden, the other axis will stay centered.
* Fixes the `GlobalPositionStrategy` adding an unnecessary `0px` transform.
* Makes the dialog scrollable.

Fixes angular#1698.
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 13, 2016
@crisbeto
feat(dialog): add configurable width, height and position
d8fc95c 
* Adds the ability to set a dialog's `width` and `height`.
* Adds the ability to set a dialog's position. If only the position in one axis is overridden, the other axis will stay centered.
* Fixes the `GlobalPositionStrategy` adding an unnecessary `0px` transform.
* Makes the dialog scrollable.
* Adds more options to the dialog demo so it's easier to test them out.

Fixes angular#1698.
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 16, 2016
@crisbeto
feat(dialog): add configurable width, height and position
1bb14f1 
* Adds the ability to set a dialog's `width` and `height`.
* Adds the ability to set a dialog's position. If only the position in one axis is overridden, the other axis will stay centered.
* Fixes the `GlobalPositionStrategy` adding an unnecessary `0px` transform.
* Makes the dialog scrollable.
* Adds more options to the dialog demo so it's easier to test them out.

Fixes angular#1698.
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 17, 2016
@crisbeto
feat(dialog): add configurable width, height and position
b18a422 
* Adds the ability to set a dialog's `width` and `height`.
* Adds the ability to set a dialog's position. If only the position in one axis is overridden, the other axis will stay centered.
* Fixes the `GlobalPositionStrategy` adding an unnecessary `0px` transform.
* Makes the dialog scrollable.
* Adds more options to the dialog demo so it's easier to test them out.

Fixes angular#1698.
tinayuangao pushed a commit that referenced this issue Nov 30, 2016
@crisbeto @tinayuangao
feat(dialog): add configurable width, height and position (#1848)
bc6cf6e 
* Adds the ability to set a dialog's `width` and `height`.
* Adds the ability to set a dialog's position. If only the position in one axis is overridden, the other axis will stay centered.
* Fixes the `GlobalPositionStrategy` adding an unnecessary `0px` transform.
* Makes the dialog scrollable.
* Adds more options to the dialog demo so it's easier to test them out.

Fixes #1698.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(dialog): add configurable width, height and position crisbeto/material2
3 participants
@jelbourn @crisbeto @bkarv