feat(overlay): overlay rtl support #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kara
added
pr: needs review
needs: discussion
googlebot
added
cla: yes
kara
added
the
blocked
kara
removed
blocked
jelbourn
reviewed
Oct 25, 2016
| this._templatePortal = new TemplatePortal(templateRef, viewContainerRef); | ||
| } | ||
|
|
||
| get overlayRef(): OverlayRef { | ||
| return this._overlayRef; | ||
| } | ||
|
|
||
| get dir(): 'ltr' | 'rtl' { |
There was a problem hiding this comment.
Type is LayoutDirection from dir.ts\
Do you need this getter at all, though, instead of just saying this._dir.value? It defaults to ltr in Dir itself.
There was a problem hiding this comment.
Ah, didn't know about that type. Handy. I think I still need the getter in case someone isn't using dir at all (to keep it optional)
| @@ -21,6 +21,9 @@ export class OverlayState { | |||
| /** The height of the overlay panel. If a number is provided, pixel units are assumed. **/ | |||
| height: number | string; | |||
|
|
|||
| /** The direction of the text in the overlay panel. */ | |||
| direction: 'ltr' | 'rtl' = 'ltr'; | |||
| @@ -59,6 +60,11 @@ export class OverlayRef implements PortalHost { | |||
| } | |||
| } | |||
|
|
|||
| /** Updates the text direction of the overlay panel. **/ | |||
| private updateDirection() { | |||
| this._pane.style.direction = this._state.direction; | |||
There was a problem hiding this comment.
Instead of setting the css direction property, it should probably use do
this._pane.setAttribute('dir', this._state.direction);
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on #1591 (needs rebase). Adds RTL support to overlay ref and position strategy. APIs need discussion.
r: @jelbourn