Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snackbar is unreadable when using border-box: box-sizing #1412

Closed
fxck opened this issue Oct 3, 2016 · 1 comment · Fixed by #1413
Closed

snackbar is unreadable when using border-box: box-sizing #1412

fxck opened this issue Oct 3, 2016 · 1 comment · Fixed by #1413
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@fxck
Copy link
Contributor

fxck commented Oct 3, 2016 •
edited
Loading

I'm setting border-box to box-sizing globally(pretty standard thing nowadays) and snackbar apparently requires content-box, I guess it should be explicitly defined in its styles then.

Otherwise it looks like this

image

and is hardly readable.
@fxck fxck changed the title default snackbar height is too low snackbar is unreadable when using border-box: box-sizing Oct 3, 2016
@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Oct 3, 2016
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 3, 2016
@crisbeto
fix(snack-bar): add explicit box-sizing
5e4b450 
Fixes the snack bar not being readable in the cases where `box-sizing: border-box` is applied globally.

Fixes angular#1412.
@crisbeto crisbeto mentioned this issue Oct 3, 2016
Merged
jelbourn pushed a commit that referenced this issue Oct 5, 2016
@crisbeto @jelbourn
fix(snack-bar): add explicit box-sizing (#1413)
580da74 
Fixes the snack bar not being readable in the cases where `box-sizing: border-box` is applied globally.

Fixes #1412.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(snack-bar): add explicit box-sizing crisbeto/material2
2 participants
@jelbourn @fxck