Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aot): change @Inputs to not be private #1289

Merged
merged 1 commit into from
Sep 21, 2016
Merged

fix(aot): change @Inputs to not be private #1289

merged 1 commit into from
Sep 21, 2016

Conversation

jelbourn
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 21, 2016
@jelbourn jelbourn mentioned this pull request Sep 21, 2016
Merged
@hansl
Copy link
Contributor

hansl commented Sep 21, 2016

Restarted the e2e tests.

@jelbourn
Copy link
Member Author

e2e tests seem good now

kara
kara approved these changes Sep 21, 2016
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added the action: merge The PR is ready for merge by the caretaker label Sep 21, 2016
@kara kara merged commit b284dd4 into angular:master Sep 21, 2016
josephperrott pushed a commit to josephperrott/components that referenced this pull request Sep 21, 2016
@jelbourn @josephperrott
fix(aot): change @inputs to not be private (angular#1289)
8b79e1d
josephperrott pushed a commit to josephperrott/components that referenced this pull request Sep 22, 2016
@jelbourn @josephperrott
fix(aot): change @inputs to not be private (angular#1289)
83b15fd
@jelbourn jelbourn deleted the aot-fix branch September 13, 2017 04:34
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees

@hansl hansl

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jelbourn @hansl @kara @googlebot