This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
chips: remove icon is larger in 1.1.0 vs 1.0.9 #9619
Labels
- Breaking Change
has: Pull Request
A PR has been created to address this issue
P2: required
Issues that must be fixed.
resolution: fixed
severity: regression
This issue is related to a regression
type: bug
type: spec alignment
For issues related to aligning with the Material Design Spec
Milestone
Actual Behavior:
What is the issue? *
The remove icons for md-chips are 24px in the 1.1 version. They used to be 18px.
The change was not intentional but due to the min-width, min-height properties that have now been added in md-icon.
All references to md-icon in the code (where they override width and height) need to be fixed.
What is the expected behavior?
The remove icons should be 18px. This is what this code is trying to do:
https://github.com/angular/material/blob/master/src/components/chips/chips.scss#L130
This needs to include now:
min-height: $chip-delete-icon-size;
min-width: $chip-delete-icon-size;
I believe that the same problem may be happening in other places like here:
material/src/components/list/list.scss
Line 62 in dfc9ae7
CodePen (or steps to reproduce the issue): *
CodePen Demo which shows your issue:
https://material.angularjs.org/latest/demo/chips
Details:
Inspect the 'X' icons
Angular Versions: *
Angular Version:
1.5.5Additional Information:
Browser Type:
ChromeStack Traces:
Shortcut to create a new CodePen Demo.
Note:
*
indicates required information. Without this information, your issue may be auto-closed.The text was updated successfully, but these errors were encountered: