This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(menuBar): Fix hovering consecutive nested menus. #7361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $timeout = _$timeout_; | ||
| $animate = _$animate_; | ||
| })); | ||
|
|
There was a problem hiding this comment.
Can likely use $material.flushInterimElement() instead
topherfangio
force-pushed
the
fix-menubar-adjacent-submenus-6685
branch
from
0a939ee to
ba0e127
Compare
Fix issue where hovering two consecutive nested menus would not properly open the second nested menu. Also adds a test and fixes an issue where the focusMenu() method of the menu bar controller would not focus the first menu if none was already selected. Fixes angular#6685.
topherfangio
force-pushed
the
fix-menubar-adjacent-submenus-6685
branch
from
ba0e127 to
c750df5
Compare
topherfangio
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where hovering two consecutive nested menus would not properly open the second nested menu.
Also adds a test and fixes an issue where the
focusMenu()method of the menu bar controller would not focus the first menu if none was already selected.Fixes #6685.