This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(speedDial): Ensure closed scale animation actions are invisible. #6786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed. When using the `scale` animation, the FAB Speed Dial's action items could sometimes appear as small dots on the screen even when the component was closed. This was due to an old bug where closing a dialog from a hidden action item was throwing an issue. This has since been fixed so we can revert this back to the original code that used `scale(0)` instead of `scale(0.1)` which ensured that the dialog always had a button to animate to when closing. Also fix an issue with the `ng-hide` animation in the "More Options" demo. Fixes angular#6344. Fixes angular#6670.
topherfangio
added
P1: urgent
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
scaleanimation, the FAB Speed Dial's action items couldsometimes appear as small dots on the screen even when the component was
closed.
This was due to an old bug where closing a dialog from a hidden action
item was throwing an issue. This has since been fixed so we can revert
this back to the original code that used
scale(0)instead ofscale(0.1)which ensured that the dialog always had a button to animateto when closing.
Also fix an issue with the
ng-hideanimation in the "More Options" demo.Fixes #6344. Fixes #6670.