-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat(input): allow skip hidden inputs #6425
Conversation
I think this warrants a note in the docs about how we skip inputs. Otherwise, LGTM. |
61bc87f
to
d0a488c
Compare
@topherfangio - I added a note to the PS: CI is still failing due Karma (will be fixed in ws@1.0.0) |
Let's change the wording to this: A single Exception: Hidden inputs ( |
3bad9a8
to
9bfbd0d
Compare
If I got your new wording right (with the divider and so on), it should look like this? (bold exception seems to be smaller as the actual text is). Still needs work? @topherfangio |
@topherfangio - Can you review the documentation message? |
@ThomasBurleson LGTM; not sure which milestone you want this in. Can you please take a look? |
I'm going to go ahead and delay this until 1.1.0 as it could affect some of our existing users. @devversion Can you please amend the commit message with a BREAKING CHANGE note about how we now skip inputs. We do it in the commit message because our Changelog process automatically pulls from there when noting breaking changes. |
9bfbd0d
to
7c5712f
Compare
BREAKING CHANGE: inputs with type `hidden` will be skipped by the `input-container` Fixes angular#2153
7c5712f
to
9ffff47
Compare
@topherfangio Done - Just updated the PR description too, so you can see it there. |
BREAKING CHANGE: inputs with type `hidden` will be skipped by the `input-container` Fixes angular#2153 Closes angular#6425
inputs with type
hidden
will be skipped by theinput-container
breaking
fixes #2153