fix(textarea): text area auto grow fix #5636
Conversation
Textarea should grow automatically if no `rows` attribute is specified. Texarea should stay fixed with given `rows` attribute (no growing or shrinking) Fixes angular#5627
EladBezalel
added
the
needs: manual testing
| var rows = Math.max(min_rows, Math.round(node.scrollHeight / lineHeight)); | ||
| var rows = Math.min(min_rows, Math.round(node.scrollHeight / lineHeight)); | ||
| node.style.height = lineHeight * rows + "px"; | ||
|
|
||
| node.setAttribute("rows", rows); |
There was a problem hiding this comment.
I am confused by your conversation comments. I thought you said the "rows" attribute should be removed to fix auto-grow ?
There was a problem hiding this comment.
No, if the attribute rows is not specified, the rows should get a dynamic value of rows, which auto grows and auto shrinks. If there is the ``rows` attribute specified the textarea should not grow and shrink, it should stay fixed at the specified amount of rows
There was a problem hiding this comment.
Why did you change Math.max to Math.min? I have my textarea set to rows="3" and want it to stay at a minimum of 3 rows, growing if necessary. With your Math.min, the "min_rows" variable (and hence the "rows" attribute) basically becomes "max_rows", which seems unintended.
(edit: ah, see you've already fixed it in master: devversion@d807b8f. Thanks!)
There was a problem hiding this comment.
Thanks for having a look at this things 😄
ThomasBurleson
removed
the
needs: manual testing
ThomasBurleson
added
the
pr: merge ready
Textarea should grow automatically if no
rowsattribute is specified.Textarea should stay fixed with given
rowsattribute (no growing or shrinking).If there are other thinks of the textarea, not wished as I fixed it, please tell me.
I'm always up for improving my PR through suggestions or wishes.
Fixes #5627