Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-datepicker min-max demo STILL doesn't work on Safari #5275

Closed
colinskow opened this issue Oct 20, 2015 · 3 comments
Closed

md-datepicker min-max demo STILL doesn't work on Safari #5275

colinskow opened this issue Oct 20, 2015 · 3 comments
Assignees
Milestone

Comments

@colinskow
Copy link
Contributor

@ThomasBurleson @kseamon

I'm opening a new issue because #4950 was incorrectly closed.

On Safari the datepicker min-max demo infinitely loops the bottom two months. It stops correctly at the maximum date on Chrome. The cause is that a $watchCollection on virtualRepeatController gets called 3 times on Safari and only 2 times on Chrome, thus inserting repeated elements into the scroller.

This PR #5009 by @mhchen fixes it. Although it only patches the symptom of the problem because we haven't identified the root cause yet. Further investigation may reveal a better solution, but this works for now.

Ideally this should be fixed for the 0.12.0 release.

@jelbourn
Copy link
Member

jelbourn commented Nov 2, 2015

@colinskow looks like that PR should have been merged, but was forgotten.

@colinskow
Copy link
Contributor Author

That's why I've been nudging you ;-)

@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc3, 1.0-rc4 Nov 7, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc4, 1.0-rc5 Nov 16, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc5, 1.0-rc7, 1.0-rc8 Nov 25, 2015
@jelbourn
Copy link
Member

jelbourn commented Dec 1, 2015

That PR was actually merged, so hopefully this should be fixed now. Let me know if that's not the case.

@jelbourn jelbourn closed this as completed Dec 1, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants