Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(select): fix cycle option focus after keyboard search #2616

Closed
wants to merge 2 commits into from

Conversation

brandom
Copy link
Contributor

@brandom brandom commented Apr 29, 2015

After keyboard search option focus cycling would start from previously focused element

Review on Reviewable

After keyboard search option focus cycling would start from previously focused element
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@brandom
Copy link
Contributor Author

brandom commented Apr 29, 2015

@googlebot Added primary Github email to CLA.

Search would not work properly with duplicate keydown listeners
@ThomasBurleson ThomasBurleson added this to the 0.10.0 milestone Apr 29, 2015
@ThomasBurleson ThomasBurleson self-assigned this Apr 29, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 0.10.0, 0.10.1 Jul 1, 2015
@ThomasBurleson
Copy link
Contributor

@brandom - You need to sign a CLA for account also.

@brandom
Copy link
Contributor Author

brandom commented Jul 1, 2015

@ThomasBurleson The first commit that did not pass was accidentally committed under my work email address. I just added the email address to my Github account as well as the CLA. Do I need to create another PR or will @googlebot pick this up?

@googlebot
Copy link

CLAs look good, thanks!

@ThomasBurleson
Copy link
Contributor

@rschmukler - can you review this?

@rschmukler
Copy link
Contributor

@brandom LGTM, merged! Thanks!!

@brandom
Copy link
Contributor Author

brandom commented Jul 6, 2015

@rschmukler Thanks! This branch has another commit for the same component that was not merged. Was this intentional?

@rschmukler
Copy link
Contributor

@brandom cc8850b and 3e3eb9e both made it in, did I miss something else?

@brandom
Copy link
Contributor Author

brandom commented Jul 6, 2015

@rschmukler Odd, github says the branch has unmerged commits and I only see 3e3eb9e in this thread. However clicking the link for cc8850b proves this is not the case so carry on 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants