Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

fix(ngClass): should properly remove classes without fallback #995

Merged
merged 2 commits into from
Jan 15, 2019

Conversation

CaerusKaru
Copy link
Member

@CaerusKaru CaerusKaru commented Jan 15, 2019

In cases where a fallback ngClass is not defined, the directive had
no way of knowing to remove its ngClass on deactivation because the
removeStyles method has no effect on ngClass (this is the default
for all other directives). By specifying an empty default fallback, we
ensure that on deactivation, if no other default is specified, the
directive will correctly fallback to an empty string case.

Fixes #992

@CaerusKaru CaerusKaru added in-progress P1 Urgent issue that should be resolved before the next re-lease labels Jan 15, 2019
@CaerusKaru CaerusKaru added this to the 7.0.0-beta.24 milestone Jan 15, 2019
@ThomasBurleson
Copy link
Contributor

In the commit body, would you explain why this fix works ?

@CaerusKaru
Copy link
Member Author

@ThomasBurleson added

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
@CaerusKaru CaerusKaru deleted the adam/fix-issue-992 branch May 10, 2020 01:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes P1 Urgent issue that should be resolved before the next re-lease pr: needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngClass with breakpoints doesn't remove class once added.
3 participants