This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
fix(ngClass): should properly remove classes without fallback #995
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where a fallback
ngClass
is not defined, the directive hadno way of knowing to remove its
ngClass
on deactivation because theremoveStyles
method has no effect onngClass
(this is the defaultfor all other directives). By specifying an empty default fallback, we
ensure that on deactivation, if no other default is specified, the
directive will correctly fallback to an empty string case.
Fixes #992