Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

feat(api): add responsive API for img elements #382

Merged
merged 2 commits into from
Aug 18, 2017

Conversation

ThomasBurleson
Copy link
Contributor

  • add ImgSrcsetDirective
    • to inject elements to support responsive images
    • Inject a element for every srcset. in the HTML markup of an element contained in a elemen
    • support usages without <picture> parents
  • add responsive API to img.src: src.md, src.lt-lg, src.gt-xs, etc.
  • repackage API classes to easily distinguish flexbox APIs and extended responsive APIs

Closes #366, Fixes #81, Fixes #376.

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Aug 17, 2017
@ThomasBurleson
Copy link
Contributor Author

ThomasBurleson commented Aug 17, 2017

This PR uses the work (and changes and approvals) from PR #366. It adds:

  • more unit tests
  • support for responsive img.src APIs
  • repackaging of API classes

screen shot 2017-08-17 at 9 22 13 am

@benbraou - please confirm the use of your commit here in this PR. Can you also review the new additions img-src.ts and img-src.spec.ts ?
@andrewseguin - can you review these two files also? No need to review the other files as Miles and Ben and I reviewed those in PR #366.

Once this all looks good, let's merge ASAP as this is the LAST merge before we release Beta.9.

@ThomasBurleson ThomasBurleson removed the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Aug 17, 2017
@ThomasBurleson ThomasBurleson added this to the v2.0.0-beta.9 milestone Aug 17, 2017
@ThomasBurleson ThomasBurleson added the P1 Urgent issue that should be resolved before the next re-lease label Aug 17, 2017
@andrewseguin
Copy link
Contributor

img-src.ts and img-src.spec.ts look alright to me, from a naive review

@benbraou
Copy link

I am starting the review

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Aug 17, 2017
@ThomasBurleson ThomasBurleson force-pushed the thomas/fix-pr-366 branch 2 times, most recently from fc6ed31 to 64f7500 Compare August 17, 2017 21:58
@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Aug 17, 2017
@ThomasBurleson
Copy link
Contributor Author

ThomasBurleson commented Aug 17, 2017

@benbraou - based on your feedback and our continued efforts with testing on ImgSrcsetDirective, I have removed that functionality from this PR.

We will keep PR #366 open for more tests, commits, and stabilizations.

@ThomasBurleson ThomasBurleson added the pr: lgtm This PR has been approved by the reviewer label Aug 17, 2017
@angular angular deleted a comment from googlebot Aug 18, 2017
@angular angular deleted a comment from benbraou Aug 18, 2017
@ThomasBurleson ThomasBurleson force-pushed the thomas/fix-pr-366 branch 3 times, most recently from fd62845 to b6df7b8 Compare August 18, 2017 16:02
…ements

* add responsive API to img.src:  src.md, src.lt-lg, src.gt-xs, etc.
* repackage API classes to easily distinguish flexbox APIs and  extended responsive APIs

Closes #366, Fixes #376.
kara added a commit that referenced this pull request Aug 21, 2017
@ThomasBurleson ThomasBurleson deleted the thomas/fix-pr-366 branch September 13, 2017 22:12
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes P1 Urgent issue that should be resolved before the next re-lease pr: lgtm This PR has been approved by the reviewer pr: needs presubmit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImgSrcsetDirective - Support Responsive src API add new API fxSrc for responsive features Image element
4 participants