-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
md-menu: renders off page #2852
Comments
This should've been fixed in master by #2677. You can try out the latest from |
Ah perfect - do we know if the issue regarding unit tests is also fixed in master? |
I'm not sure about the unit test issue, all of our unit tests pass both locally and on the CI. |
Yeah if you clone the repo, or take a look at this.. https://travis-ci.org/ExcelerationDesigns/ng-cli-starter just dropping the menu causes all unit tests to fail because of the subscription in the menu |
Alright, but it's better to keep all of the discussions regarding the unit test issue on #1913. |
True, but figured I might give that some love because I can't commit the change unless I get the unit tests up and working. :) Thanks for the time on this tho. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Issue with md-menu &
y-position="above"
and the menu rendering off page. Additionally all unit tests fail due to #1913What is the expected behavior?
The menu should populate above the clicked point.
What is the current behavior?
The menu is currently showing beneath the clicked point, and rendering off page.
What are the steps to reproduce?
npm install
localhost:4200
ng test
will also demonstrate all unit tests failing. The solution in [md-menu][bug] Tests crash in MdMenu.ngOnDestroy #1913 is confirmed as working.Providing a Plunker (or similar) is the best way to get the team to see your issue.
Plunker template: http://plnkr.co/edit/o077B6uEiiIgkC0S06dd
What is the use-case or motivation for changing an existing behavior?
Make it so the user can actually click the menu. :)
Which versions of Angular, Material, OS, browsers are affected?
Is there anything else we should know?
Don't think so!
The text was updated successfully, but these errors were encountered: