Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR worth making? #1939

Closed
John0x opened this issue Nov 20, 2016 · 4 comments
Closed

PR worth making? #1939

John0x opened this issue Nov 20, 2016 · 4 comments

Comments

@John0x
Copy link

John0x commented Nov 20, 2016

Hey, material2 has a lot of problems with angular universal right now and I was wondering whether or not it would be worth the effort to create a PR fixing those problems?

I saw that there are a lot of PR's that are waiting to merged for qutie some time now. Are the material2 maintainers too busy right now to take care of them?

@fxck
Copy link
Contributor

fxck commented Nov 25, 2016

yo @jelbourn @kara

#1136 none of the Be as contributor friendly as possible part unfortunately happened

@jelbourn
Copy link
Member

I chatted with the maintainers of Universal and they said that we should hold off on any work related to that as they do some large-scale refactorings and much of the code is moved into angular/angular. I'll update #308 when we're ready to start making changes to support it.

@fxck Keep in mind that last week was a holiday week in the US.

@fxck
Copy link
Contributor

fxck commented Nov 28, 2016

It's not only about this issue, issues are often not properly labelled and/or people don't get replies from team members and it causes some confusion. I know it's pain in the ass to manage, but isn't it worth it?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants