Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AngularFireAuth.authState incorrectly uses onIdTokenChanged #2307

Closed
sarunint opened this issue Feb 3, 2020 · 1 comment
Closed

AngularFireAuth.authState incorrectly uses onIdTokenChanged #2307

sarunint opened this issue Feb 3, 2020 · 1 comment

Comments

@sarunint
Copy link
Contributor

sarunint commented Feb 3, 2020

Version info

Angular: 8.2.14

Firebase: 7.8.0

AngularFire: 5.4.0

How to reproduce these conditions

In #2294, AngularFireAuth.authState had been incorrectly refactored to used auth.onIdTokenChanged. It should be auth.onAuthStateChanged

this.authState = new Observable<User | null>(subscriber => {
return zone.runOutsideAngular(() => this.auth.onIdTokenChanged(subscriber));
}).pipe(keepUnstableUntilFirst);;

This only applies to v5 branch, does not effect master branch.

@jamesdaniels
Copy link
Member

Addressed in 5.4.1, thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants