Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): add support for ng1/ng2 migration #12160

Merged
merged 1 commit into from
Oct 20, 2016

Conversation

vsavkin
Copy link
Contributor

@vsavkin vsavkin commented Oct 7, 2016

No description provided.

@vsavkin vsavkin added action: review The PR is still awaiting reviews from at least one requested reviewer area: router labels Oct 7, 2016
@vsavkin vsavkin force-pushed the router_ng1_ng2 branch 2 times, most recently from 8830d43 to 603c5ef Compare October 12, 2016 19:16
@vicb vicb added pr_state: LGTM action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: merge The PR is ready for merge by the caretaker labels Oct 19, 2016
@vicb
Copy link
Contributor

vicb commented Oct 19, 2016

Need to update the public API

@vicb
Copy link
Contributor

vicb commented Oct 19, 2016

LGTM

@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Oct 19, 2016
@alxhub alxhub merged commit 8b9ab44 into angular:master Oct 20, 2016
btrigueiro pushed a commit to btrigueiro/angular that referenced this pull request Oct 21, 2016
@finalxcode
Copy link

@vicb what's mean of "LGTM"?

@skreborn
Copy link
Contributor

@finalxcode As far as I know, it stands for "Looks Good To Me".

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: router cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants