This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($http): add the PATCH shortcut back #5894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shortcut was dropped because it had a lot of unkowns about PATCH. Since we already know that using PATCH is good (http://www.mnot.net/blog/2012/09/05/patch), and only IE8 has issues with that, let's add the shortcut back.
|
I think we'll get this into 1.3, probably one of the early releases |
|
@caitp what should we do to get this merged? |
|
LGTM; can I merge it, @IgorMinar?. |
|
Yup. Thanks!
|
|
@cironunes Landed, thanks! |
ckknight
pushed a commit
to ckknight/angular.js
that referenced
this pull request
Jul 16, 2014
The shortcut was dropped because it had a lot of unkowns about PATCH. Since we already know that using PATCH is good (http://www.mnot.net/blog/2012/09/05/patch), and only IE8 has issues with that, let's add the shortcut back. Closes angular#5894
|
Any intention to add back the PATCH to version 1.2 ? |
|
Angular 1.2 is feature-frozen. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shortcut was dropped because it had a lot of unkowns about PATCH.
Since we already know that using PATCH is good (http://www.mnot.net/blog/2012/09/05/patch), and only IE8 has issues with that, let's add the shortcut back.
Closes #5823