This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(compile): directive controller order fix #2738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a directive defines a templateUrl, directives on the top level element will be applied after the directives on the original node even if the directive defines `replace: true` and `transclude: true` BREAKING CHANGE: * The compilation and linking order of directives that are defined on the top level element of an external template are compiled and linked after the directives of the original node
|
I cleaned up and simplified the test: 5b2223a46c22b64b3dc62b86eee472918ae7b3a2 |
|
this is a real bug but I'm not sure if the proposed solution is the right one. investigating... |
|
@IgorMinar I am not sure if this is the proper solution or if something more elaborate is needed. One way or another, it is very important for the test to have |
|
I commented it out just to get over the error, it is now uncommented. |
IgorMinar
added a commit
to IgorMinar/angular.js
that referenced
this pull request
Jul 22, 2013
Previously it was possible to get into a situation where child controller was being instantiated before parent which resulted in an error. Closes angular#2738
IgorMinar
added a commit
that referenced
this pull request
Jul 22, 2013
Previously it was possible to get into a situation where child controller was being instantiated before parent which resulted in an error. Closes #2738
|
Are there any plans to create a new (possibly unstable) version containing this fix? |
|
@paulyoung I guess it is in 1.2.0rc1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are two nested directives that the parent directive defines a controller, has
transclude: true, has a templateUrl, the template has on the top level element the directiveng-transcludethen the directiveng-transcludeis applied before the parent directive. Now, if there is a nested child directive that also defines a controller and this controller needs to reference the parent controller, then given thatng-transcludewas applied before the parent directive controller, the child directive is not able to reference the parent directive controller.This patch changes this so the directives on the top level element of the template are applied after the directives on the original node