Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

feat(directive): ng:srcset #2601

Closed
wants to merge 1 commit into from
Closed

Conversation

samaxes
Copy link
Contributor

@samaxes samaxes commented May 7, 2013

New directive to support {{}} expressions on the new HTML5 srcset attribute.

New directive to support `{{}}` expressions on the new HTML5 `srcset` attribute.
@petebacondarwin
Copy link
Member

  • Contributor signed CLA now or in the past (if you just signed, leave a comment here with your real name for cross reference)
  • Feature improves existing core functionality
  • API is compatible with existing Angular apis and relevant standards (if applicable)
  • PR doesn't contain a breaking change
  • PR contains unit tests
  • [ ] PR contains e2e tests (if suitable)
  • PR contains documentation update
  • PR passes all tests on Travis (sanity)
  • PR passes all tests on ci.angularjs.org (cross-browser compatibility)
  • PR is rebased against recent master
  • PR is squashed into one commit per logical change
  • PR's commit messages are descriptive and allows us to autogenerate release notes (required commit message format)
  • All changes requested in review have been implemented

@petebacondarwin
Copy link
Member

Landed at d551d72. Thanks.

@samaxes
Copy link
Contributor Author

samaxes commented May 14, 2013

Thanks Pete.
Will this directive also be included on the stable branch?

@samaxes samaxes deleted the srcset-support branch May 14, 2013 20:56
@cburgdorf
Copy link
Contributor

@samaxes yes, it landed in master.

@samaxes
Copy link
Contributor Author

samaxes commented May 14, 2013

Just to be sure, by stable we mean v1.0.x branch, right?

@cburgdorf
Copy link
Contributor

@samaxes ah, sorry I got you wrong then. Don't know about that. But I guess it's unlikely to be backported into the 1.0.x release.

@samaxes
Copy link
Contributor Author

samaxes commented May 14, 2013

That’s too bad. Thanks Christoph!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants