Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngTransclude): remove terminal: true #16412

Merged
merged 1 commit into from
Jan 17, 2018

Conversation

Narretz
Copy link
Contributor

@Narretz Narretz commented Jan 15, 2018

This was introduced in commit 2adaff0,
but made obsolete in 41f3269.

Fixes #16411

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Fix/Feature: Docs have been added/updated
  • Fix/Feature: Tests have been added; existing tests pass

Other information:

This was introduced in commit 2adaff0,
but made obsolete in 41f3269.

Fixes angular#16411
Copy link
Member

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Narretz Narretz merged commit ab386cd into angular:master Jan 17, 2018
@Narretz Narretz deleted the fix-ngTransclude-terminal branch January 17, 2018 11:03
Narretz added a commit to Narretz/angular.js that referenced this pull request Jan 17, 2018
This was introduced in commit 2adaff0,
but made obsolete in 41f3269.

Fixes angular#16411
Closes angular#16412
Narretz added a commit that referenced this pull request Jan 17, 2018
This was introduced in commit 2adaff0,
but made obsolete in 41f3269.

Fixes #16411
Closes #16412
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngTransclude breaks directive execution when priority is set to -1 or lower
3 participants