-
Notifications
You must be signed in to change notification settings - Fork 27.5k
WIP fix(ngMessages): fix orphaned ng-message comments when using ng-if #16404
WIP fix(ngMessages): fix orphaned ng-message comments when using ng-if #16404
Conversation
Fix an issue where if you remove ng-message comments with ng-if before they are attached to the dom you will get an error when ngMessages tries to reveal them.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@CodySchaaf It looks like your commit author isn't linked to your github account, you probably wanna fix that, despite this PR getting merged or not (it's useful for other PR's/repos aswel) |
@CodySchaaf the PR should have the master branch as merge target, not 1.5.x. We merge all PRs into master first, because that's the most up to date code. We actually don't update 1.5.x. anymore, only master and 1.6.x Can you also add a test case in ngMessagesSpec that is fixed by this change? You should be able to adapt one of the tests. |
I think #16406 should fix this issue |
…ached Closes angular#16389 Closes angular#16404 Closes angular#16406
Pull request for help on issue #16389