From 2c0753225a506185bf8b09b344e7615957009f02 Mon Sep 17 00:00:00 2001 From: Brian Ford Date: Thu, 11 Jul 2013 15:32:33 -0700 Subject: [PATCH] revert: feat(ngDocs): add links to source for API This reverts commit 61fb5863df4afe0fad688a44ff78b245b8439db2. --- docs/spec/sourceLinkSpec.js | 29 ----------------------------- docs/src/ngdoc.js | 13 ++----------- docs/src/templates/css/docs.css | 3 +-- 3 files changed, 3 insertions(+), 42 deletions(-) delete mode 100644 docs/spec/sourceLinkSpec.js diff --git a/docs/spec/sourceLinkSpec.js b/docs/spec/sourceLinkSpec.js deleted file mode 100644 index 3dc73cc85c37..000000000000 --- a/docs/spec/sourceLinkSpec.js +++ /dev/null @@ -1,29 +0,0 @@ -var ngdoc = require('../src/ngdoc.js'); -var gruntUtil = require('../../lib/grunt/utils.js'); - -describe('Docs Links', function() { - - describe('links', function() { - var doc; - - beforeEach(function() { - doc = new ngdoc.Doc("@ngdoc function\n@name ng.filter:a\n@function"); - doc.section = 'api'; - doc.file = 'test.js'; - doc.line = 42; - doc.parse(); - }); - - it('should have an "improve this doc" button', function() { - expect(doc.html()). - toContain(' Improve this doc'); - }); - - it('should have an "view source" button', function() { - expect(doc.html()). - toContain(' View source'); - }); - - }); - -}); diff --git a/docs/src/ngdoc.js b/docs/src/ngdoc.js index d1ebb388c6ea..84a165f24ada 100644 --- a/docs/src/ngdoc.js +++ b/docs/src/ngdoc.js @@ -274,16 +274,7 @@ Doc.prototype = { dom.h(title(this.name), function() { notice('deprecated', 'Deprecated API', self.deprecated); - dom.tag('a', {href: 'http://github.com/angular/angular.js/edit/master/' + self.file, class: 'improve-docs btn btn-primary'}, function(dom) { - dom.tag('i', {class:'icon-edit'}, ' '); - dom.text(' Improve this doc'); - }); - if (self.section === 'api') { - dom.tag('a', {href: 'http://github.com/angular/angular.js/tree/v' + gruntUtil.getVersion().number + '/' + self.file + '#L' + self.line, class: 'view-source btn btn-action'}, function(dom) { - dom.tag('i', {class:'icon-zoom-in'}, ' '); - dom.text(' View source'); - }); - } + dom.tag('a', {href: 'http://github.com/angular/angular.js/edit/master/' + self.file, class: 'improve-docs btn btn-primary'}, 'Improve this doc'); if (self.ngdoc != 'overview') { dom.h('Description', self.description, dom.html); } @@ -306,7 +297,7 @@ Doc.prototype = { ////////////////////////// function notice(name, legend, msg){ - if (self[name] === undefined) return; + if (self[name] == undefined) return; dom.tag('fieldset', {'class':name}, function(dom){ dom.tag('legend', legend); dom.text(msg); diff --git a/docs/src/templates/css/docs.css b/docs/src/templates/css/docs.css index 27d2bcd39e51..0bb631d8cc13 100644 --- a/docs/src/templates/css/docs.css +++ b/docs/src/templates/css/docs.css @@ -86,9 +86,8 @@ img.AngularJS-small { /* Content */ /* =============================== */ -.improve-docs, .view-source { +.improve-docs { float: right; - margin: 0 5px; } .hint {