Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): Use appropriate packageManager for linking #5524

Closed
wants to merge 1 commit into from

Conversation

abdulhaq-e
Copy link
Contributor

When creating a new project using the --link-cli option, the
linking command was hard-coded to use npm link @angular/cli.
This commit replicates the behaviour of npm-install where the
package manager is obtained from the global config and is then
used for linking.

@abdulhaq-e
Copy link
Contributor Author

I had some issues with the previous PR so I opened a new one (based on a separate branch)

When creating a new project using the --link-cli option, the
linking command was hard-coded to use npm link @angular/cli.
This commit replicates the behaviour of npm-install where the
package manager is obtained from the global config and is then
used for linking.
@abdulhaq-e
Copy link
Contributor Author

I have refactored based on the latest commit.

dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
When creating a new project using the --link-cli option, the
linking command was hard-coded to use npm link @angular/cli.
This commit replicates the behaviour of npm-install where the
package manager is obtained from the global config and is then
used for linking.

Close angular#5524
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants