Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@ngtools/webpack): invalidate all the files changed #4542

Merged
merged 1 commit into from
Feb 9, 2017

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Feb 8, 2017

Webpack only passes the first file that was changed. If there are multiple,
we need to validate all of them. For that we result to listening to Watchpack
directly.

Fixes #4453
Fixes #4511

@hansl hansl force-pushed the fix-invlaidate-bug branch 2 times, most recently from 509091a to 3854212 Compare February 9, 2017 00:37
Webpack only passes the first file that was changed. If there are multiple,
we need to validate all of them. For that we result to listening to Watchpack
directly.
@hansl hansl force-pushed the fix-invlaidate-bug branch from 3854212 to cc4fec1 Compare February 9, 2017 05:45
@hansl hansl merged commit 9548d90 into angular:master Feb 9, 2017
@hansl hansl deleted the fix-invlaidate-bug branch February 9, 2017 19:27
klinki added a commit to klinki/windup-web that referenced this pull request Feb 17, 2017
There was a serious bug in @ngtools which caused not all changed files were recompiled. This bug should be fixed by newer version. For more details see angular/angular-cli#4542
jsight pushed a commit to windup/windup-web that referenced this pull request Feb 17, 2017
There was a serious bug in @ngtools which caused not all changed files were recompiled. This bug should be fixed by newer version. For more details see angular/angular-cli#4542
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
Webpack only passes the first file that was changed. If there are multiple,
we need to validate all of them. For that we result to listening to Watchpack
directly.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken ng serve auto-refresh Re-compile does not always trigger browser update
3 participants