Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): tsconfig should support other formats too #4469

Merged
merged 1 commit into from
Feb 8, 2017

Conversation

sumitarora
Copy link
Contributor

Using the read function from the typescript to read config file.
Fixes: #3970

@hansl
Copy link
Contributor

hansl commented Feb 6, 2017

2 things:

  1. also make this change for reading the angular-cli.json file, and
  2. add an e2e test please :)

Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above nits.

@sumitarora sumitarora force-pushed the feat-file-support branch 4 times, most recently from 3fac58f to 182be25 Compare February 8, 2017 00:07
@hansl hansl merged commit aa87de7 into angular:master Feb 8, 2017
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
@sumitarora sumitarora deleted the feat-file-support branch March 24, 2017 16:35
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON should be in UTF-8...
3 participants