fix(@ngtools/webpack): prevent emitting sourcemaps #4221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hansl can you review? |
dobbydog
force-pushed
the
fix-emit-sourcemaps
branch
from
e2fd262 to
d0ed70f
Compare
dobbydog
changed the title
hansl
suggested changes
Jan 30, 2017
| // If it wasn't there - delete it. | ||
| delete this._parentCompilation.assets[outputName]; | ||
| } | ||
| Object.keys(childCompilation.assets).forEach((filename) => { |
There was a problem hiding this comment.
Nit: filename should be fileName, as it is two words.
dobbydog
added a commit
to dobbydog/angular-cli
that referenced
this pull request
Feb 1, 2017
Requested change in angular#4221
In some cases compilation of a component style generates a sourcemap and it's not deleted from assets. This would be cause hangup in Windows.
dobbydog
force-pushed
the
fix-emit-sourcemaps
branch
from
00e7ee5 to
3c41bcd
Compare
hansl
approved these changes
Feb 2, 2017
MRHarrison
pushed a commit
to MRHarrison/angular-cli
that referenced
this pull request
Feb 9, 2017
In some cases compilation of a component style generates a sourcemap and it's not deleted from assets. This would be cause hangup in Windows.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases compilation of a component style generates a sourcemap and it's not deleted from assets.
This would cause hangs in Windows and make unnecessary outputs in other platform.
may fix #3019