Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serve): Removes logic looking for config/environment.js in the project root #4057

Closed
wants to merge 10 commits into from

Conversation

celliott181
Copy link
Contributor

@celliott181 celliott181 commented Jan 16, 2017

This removes the logic for ember-cli config files in the project root. Previously the CLI package would break when this file was present and ng serve was performed. It would remain unusable until the config/environment.js file is removed and npm install is performed again.

This allows the project to be served with the config/environment.js file in place. Fixes #3531

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@celliott181
Copy link
Contributor Author

celliott181 commented Jan 16, 2017

I signed it (rebased to the proper account actually)!

@googlebot
Copy link

CLAs look good, thanks!

@celliott181 celliott181 changed the title Fix for #3531: Removes logic looking for config/environment.js in the project root fix(#3531): Removes logic looking for config/environment.js in the project root Jan 17, 2017
@celliott181 celliott181 changed the title fix(#3531): Removes logic looking for config/environment.js in the project root fix(serve): Removes logic looking for config/environment.js in the project root Jan 17, 2017
@hansl
Copy link
Contributor

hansl commented Feb 7, 2017

LGTM, thanks. Could you rebase?

Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gelliott181 sorry it took so long to get this reviewed and merged. Can you rebase though? We changed the structure and this file is now somewhere else.

@celliott181
Copy link
Contributor Author

Did you get the rebased commit? I did it late one night and wasn't sure if I pushed my master.

asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR when using 'ng serve' with a ./config/environment.js path
4 participants