-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(serve): Removes logic looking for config/environment.js
in the project root
#4057
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
I signed it (rebased to the proper account actually)! |
CLAs look good, thanks! |
config/environment.js
in the project rootconfig/environment.js
in the project root
config/environment.js
in the project rootconfig/environment.js
in the project root
LGTM, thanks. Could you rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gelliott181 sorry it took so long to get this reviewed and merged. Can you rebase though? We changed the structure and this file is now somewhere else.
Did you get the rebased commit? I did it late one night and wasn't sure if I pushed my master. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This removes the logic for ember-cli config files in the project root. Previously the CLI package would break when this file was present and
ng serve
was performed. It would remain unusable until theconfig/environment.js
file is removed andnpm install
is performed again.This allows the project to be served with the
config/environment.js
file in place. Fixes #3531