fix(new): exclude non spec files from test.ts #3538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment if you have a merge conflict, and it leaves you with `blah.spec.ts.orig` files (file used by git for diff checking), you can just add it to gitignore (might add it in another PR), but when you run `ng test` the next time, you get the error: ``` Module parse failed: <SOME_PROJECT_APP_FOLDER_PATH>\blah.spec.ts.orig Unexpected token (xx:xx) You may need an appropriate loader to handle this file type. ``` This PR excludes these false positives.
|
LGTM. Thanks for finding this! |
MRHarrison
pushed a commit
to MRHarrison/angular-cli
that referenced
this pull request
Feb 9, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment if you have a merge conflict, and it leaves you with
blah.spec.ts.origfiles (file used by git for diff checking), you can just add it to gitignore (might add it in another PR), but when you runng testthe next time, you get the error:This PR excludes these false positives.