Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly resolve WebPack loaders within npm linked modules #3419

Closed
garkbit opened this issue Dec 6, 2016 · 3 comments · Fixed by #3422
Closed

Correctly resolve WebPack loaders within npm linked modules #3419

garkbit opened this issue Dec 6, 2016 · 3 comments · Fixed by #3422
Labels
effort1: easy (hours) P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix

Comments

@garkbit
Copy link

garkbit commented Dec 6, 2016

OS?

OSX Sierra

Versions.

angular-cli: 1.0.0-beta.18
node: 6.9.1
os: darwin x64

Repro steps.

Install NPM linked package that uses a WebPack loader. Loader cannot be resolved.

The log given by the failure.

Module not found: Error: Can't resolve 'style' in '...'

Mention any other details that might be useful.

Merge #2291 was incomplete, in that it does not fully address the issue raised in #1875. It fixes module resolution, but not loader resolution. The following needs to be added to the object returned from getWebpackCommonConfig() in webpack-build-common.ts in order to match current module resolution strategy:

resolveLoader: {
  modules: [path.resolve(projectRoot, 'node_modules')]
}

Also, I would submit a pull request, but the the corporate overhead of getting a CLA in place are prohibitive.

@hansl hansl added effort1: easy (hours) P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix labels Dec 6, 2016
@hansl
Copy link
Contributor

hansl commented Dec 6, 2016

As for the CLA, it's a one time cost that really takes 5 minutes to complete. If you have legal complications I can understand, though.

@garkbit
Copy link
Author

garkbit commented Dec 6, 2016

@hansl, thank you sir.

You're right, submitting the CLA is easy enough. It's the internal process of getting an approval for it on my end that's a pain. Again, thanks for making the change. :)

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort1: easy (hours) P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants