feat(aot): creating files in a virtual fs. #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansl
force-pushed
the
aot-memory
branch
2 times, most recently
from
744c559 to
ed4e34e
Compare
filipesilva
approved these changes
Oct 2, 2016
| || access.name.text == 'bootstrapModuleFactory'); | ||
| }); | ||
|
|
||
| if (bootstrap.length != 1 |
There was a problem hiding this comment.
What about multiple bootstrap calls? Is this something AoT doesn't support?
There was a problem hiding this comment.
It doesn't support it. Having multiple bootstraps in a single file is just bad. Please note that in this case, the CLI doesn't support it but you can specify which specific module you want to bootstrap with entryModule in your webpack config.
| } catch (e) { | ||
| console.log('------'); | ||
| console.log('------'); |
hansl
force-pushed
the
aot-memory
branch
3 times, most recently
from
f263bd9 to
597a222
Compare
In addition, reading and using AST on main.ts to figure out the entry module, if not specified.
filipesilva
approved these changes
Oct 2, 2016
JJayet
pushed a commit
to JJayet/angular-cli
that referenced
this pull request
Oct 2, 2016
In addition, reading and using AST on main.ts to figure out the entry module, if not specified.
deebloo
pushed a commit
to deebloo/angular-cli
that referenced
this pull request
Oct 3, 2016
In addition, reading and using AST on main.ts to figure out the entry module, if not specified.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, reading and using AST on main.ts to figure out the entry module, if not specified.