-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack): Added ContextReplacementPlugin to remove ng test warning #2362
Conversation
a0aab8e
to
146ebf9
Compare
Looks like the appveyor build failed for an unrelated reason. Can anyone investigate/confirm? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. @hansl not sure what the AppVeyor flaking out was for on one test.
146ebf9
to
f34de7a
Compare
@TheLarkInn / @hansl - It appears it was just a flaky test. I rebased last night and now all tests pass. Let me know if there is anything else you would like me to do. |
Branch is out of date, this looks good so far, but I'd like to make sure with the most recent changes that this still passes. |
0fea7b8
to
12ad1bf
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #2359
@TheLarkInn: This is my first time working with webpack. Please let me know if there is anything else I need to do. It appears to have fixed the issue I was seeing with my project.