Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): Added ContextReplacementPlugin to remove ng test warning #2362

Closed

Conversation

delasteve
Copy link
Contributor

Fixes #2359

@TheLarkInn: This is my first time working with webpack. Please let me know if there is anything else I need to do. It appears to have fixed the issue I was seeing with my project.

@delasteve delasteve changed the title bug(webpack): Added ContextReplacementPlugin to remove ng test warning fix(webpack): Added ContextReplacementPlugin to remove ng test warning Sep 27, 2016
@delasteve delasteve force-pushed the bug/update-webpack-test-config branch from a0aab8e to 146ebf9 Compare September 27, 2016 05:10
@JohannesRudolph
Copy link
Contributor

Looks like the appveyor build failed for an unrelated reason. Can anyone investigate/confirm?

@JohannesRudolph
Copy link
Contributor

I can confirm this fixes #2359 but it does not fix #2364

Copy link
Member

@TheLarkInn TheLarkInn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @hansl not sure what the AppVeyor flaking out was for on one test.

@delasteve delasteve force-pushed the bug/update-webpack-test-config branch from 146ebf9 to f34de7a Compare October 1, 2016 05:19
@delasteve
Copy link
Contributor Author

@TheLarkInn / @hansl - It appears it was just a flaky test. I rebased last night and now all tests pass.

Let me know if there is anything else you would like me to do.

@TheLarkInn
Copy link
Member

Branch is out of date, this looks good so far, but I'd like to make sure with the most recent changes that this still passes.

@delasteve delasteve force-pushed the bug/update-webpack-test-config branch from 0fea7b8 to 12ad1bf Compare October 3, 2016 00:40
JJayet pushed a commit to JJayet/angular-cli that referenced this pull request Oct 14, 2016
texel pushed a commit to splice/angular-cli that referenced this pull request Nov 3, 2016
@delasteve delasteve deleted the bug/update-webpack-test-config branch January 17, 2017 06:32
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Critical dependency: the request of a dependency is an expression
5 participants