Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically alphabetizing barrels introduces circular dependencies in some cases #1282

Closed
Blasz opened this issue Jul 5, 2016 · 2 comments

Comments

@Blasz
Copy link

Blasz commented Jul 5, 2016

Version
$ ng --version
(node:11205) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
Could not start watchman; falling back to NodeWatcher for file system events.
Visit http://ember-cli.com/user-guide/#watchman for more info.
angular-cli: 1.0.0-beta.6
node: 6.2.1
os: linux x64
Repro steps
  1. Structure components in a shared folder where certain ordering in the barrel is necessary - http://plnkr.co/edit/vDsAp8dzqBVsl7C1G8Q7?p=preview

  2. Generate a new module in the same shared folder

    app/ $ ng generate pipe shared/something
    
  3. Angular-CLI re-orders the shared barrel file alphabetically and causes circular dependency issues

Related to angular/angular#9334 and introduced in #582

I'm not sure what the best way around this is but I think it involves a higher level discussion where, when and how barrels should be used.

@filipesilva
Copy link
Contributor

Closed as obsolete following #1455.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants