Commit
* fixed a bug: User input keys to search input isn't blocked when search-enabled is set to false and all items are selected in multiple select mode. * Revert "fixed a bug: User input keys to search input isn't blocked when search-enabled is set to false and all items are selected in multiple select mode." This reverts commit ffcf66c. * fixed a bug: User input keys to search input isn't blocked when search-enabled is set to false and all items are selected in multiple select mode.
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -383,7 +383,7 @@ uis.controller('uiSelectCtrl', | |
| ctrl.select = function(item, skipFocusser, $event) { | ||
| if (item === undefined || !_isItemDisabled(item)) { | ||
|
|
||
| if ( (!ctrl.items || !ctrl.items.length) && ! ctrl.search && ! ctrl.tagging.isActivated) return; | ||
|
|
||
| if (!item || !_isItemDisabled(item)) { | ||
| // if click is made on existing item, prevent from tagging, ctrl.search does not matter | ||
|
|
@@ -645,6 +645,9 @@ uis.controller('uiSelectCtrl', | |
| }); | ||
| } | ||
| } | ||
| }else{ | ||
| e.preventDefault(); | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong. 
chadfurman
|
||
| e.stopPropagation(); | ||
| } | ||
|
|
||
| }); | ||
|
|
||
6 comments
on commit 0d81493
There was a problem hiding this comment.
You just broke our production app with this "fix". At least bump your minor version instead of pushing it in a patch.
The search-enabled property doesn't seem to have a default value and as such this was probably null or false for us.
What happened was that npm installed the 0.19.5 version (because it matches to ^0.19.4). Because I developed the box with 0.19.4 I didn't know of the bug and as such it broke my working thing.
There was a problem hiding this comment.
Guys this "fix" breaks completely different scenario:
search-enabled is true
and it's not a multiple select
And you are typing something that empties ctrl.items.length
Everything is blocked, user can't even correct input - backspace is blocked as well
There was a problem hiding this comment.
Same as @narrowtux and @pasha-r this breaks the ability to write or delete anything
There was a problem hiding this comment.
Exactly, this just removes the ability to type anything (even switching tabs in chrome), which isn't the way I would solve disabling an input. Wouldn't it be better to set disabled="disabled" on the <input>?
There was a problem hiding this comment.
This is also a problem with 0.19.4 -- either that, or the version number in the comment atop the file didn't change: https://github.com/angular-ui/ui-select/blob/master/dist/select.js#L925
There was a problem hiding this comment.
It's not in 0.19.4 - the file comment is wrong. Easy fix is to downgrade
preventDefault and stopPropagation block user to type characters. for any async operations this is a blocker.