Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controller As on a custom Directive/Component without the Viewport #123

Closed
dhilt opened this issue Nov 1, 2016 · 1 comment
Closed

Controller As on a custom Directive/Component without the Viewport #123

dhilt opened this issue Nov 1, 2016 · 1 comment

Comments

@dhilt
Copy link
Member

dhilt commented Nov 1, 2016

Currently the ui-scroll traversing the DOM and trying to find out the ng-controller attributes. This does not work when we set "Controller As" as a property of some custom directive or component.

The case when we have ui-scroll-viewport does not affected by this issue (the explanation is here). But the case when we have no viewport is broken.
@dhilt
Copy link
Member Author

dhilt commented Nov 18, 2016

Fixed in 1.5.2 ui-scroll: https://github.com/angular-ui/ui-scroll/blob/v1.5.2/src/ui-scroll.js#L527

@dhilt dhilt closed this as completed Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dhilt