This repository has been archived by the owner on May 29, 2019. It is now read-only.
Fix typeahead validity if model is set manually #3319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test(s) please :-) |
|
Shall I add a non-regression test with the (stripped-down) example that @jengeb provided? |
|
Yes please. |
With this commit, the validity of a typeahead model is set to true if the model is set manually and the typehead directive is set to be non-editable.
andrenarchy
force-pushed
the
fix-typeahead-validity
branch
from
03847ce to
e111db7
Compare
|
Test is added and runs smoothly on travis. |
|
Thanks! |
|
Any updates? |
|
Looks good to me. Will merge soon. |
|
Landed as b004443, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit, the validity of a typeahead model is set to true if the model is set manually and the typehead directive is set to be non-editable.
Fixes #3318.
Thx to @jengeb for investigating the issue with me in a nightly hacking session. 😃