Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong default value for cname in schema.json #154

Closed
JohannesHoppe opened this issue Jul 6, 2022 · 1 comment · Fixed by #166
Closed

Wrong default value for cname in schema.json #154

JohannesHoppe opened this issue Jul 6, 2022 · 1 comment · Fixed by #166
Assignees
@JohannesHoppe
Labels
low-prio

Comments

@JohannesHoppe
Copy link
Member

Error: Property 'cname' does not match the schema. 'false' should be a 'string'.

Solved it by adding cname flag manually as github.com along with base-href.

Originally posted by @batbrain9392 in #145 (comment)

see

angular-cli-ghpages/src/deploy/schema.json

Lines 51 to 55 in 76753b0

"cname": {
"type": "string",
"description": "Generate a CNAME file for the specified domain.",
"default": false
},

@JohannesHoppe
Copy link
Member Author

The typings here are indeed wrong, an empty string should do the trick.

@JohannesHoppe JohannesHoppe self-assigned this Jul 6, 2022
@JohannesHoppe JohannesHoppe mentioned this issue Jul 6, 2022
Closed
@fmalcher fmalcher linked a pull request May 3, 2023 that will close this issue
fix: fix wrong default value for cname option in schema.json #166
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohannesHoppe JohannesHoppe

Labels
low-prio
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix wrong default value for cname option in schema.json tinesoft/angular-cli-ghpages
1 participant
@JohannesHoppe